From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sultan Alsawaf Subject: [PATCH] ip_tunnel: Fix GCC 8 warning in __ip_tunnel_create() Date: Wed, 6 Jun 2018 17:27:15 -0700 Message-ID: <20180607002715.25079-1-sultanxda@gmail.com> Cc: netdev@vger.kernel.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org To: sultanxda@gmail.com Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:33248 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752956AbeFGA1i (ORCPT ); Wed, 6 Jun 2018 20:27:38 -0400 Received: by mail-qt0-f195.google.com with SMTP id l10-v6so3210708qtj.0 for ; Wed, 06 Jun 2018 17:27:37 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: By passing a limit of 2 bytes to strncat, GCC 8 thinks that strncat is limited to writing fewer bytes than what it's supposed to append to the name here. However, strncat appends n+1 bytes to the destination, so this is correct even though it doesn't look right. Since the bounds are checked on the line above this, just remove the string bounds checks entirely to silence the warning since they're unneeded. Signed-off-by: Sultan Alsawaf --- net/ipv4/ip_tunnel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index 38d906baf1df..c4f5602308ed 100644 --- a/net/ipv4/ip_tunnel.c +++ b/net/ipv4/ip_tunnel.c @@ -261,8 +261,8 @@ static struct net_device *__ip_tunnel_create(struct net *net, } else { if (strlen(ops->kind) > (IFNAMSIZ - 3)) goto failed; - strlcpy(name, ops->kind, IFNAMSIZ); - strncat(name, "%d", 2); + strcpy(name, ops->kind); + strcat(name, "%d"); } ASSERT_RTNL(); -- 2.17.1