From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net] net: fddi: fix a possible null-ptr-deref Date: Fri, 08 Jun 2018 18:48:14 -0400 (EDT) Message-ID: <20180608.184814.2215583284330084945.davem@davemloft.net> References: <20180608025825.25716-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: yuehaibing@huawei.com Return-path: In-Reply-To: <20180608025825.25716-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: YueHaibing Date: Fri, 8 Jun 2018 10:58:25 +0800 > bp->SharedMemAddr is set to NULL while bp->SharedMemSize lesser-or-equal 0, > then memset will trigger null-ptr-deref. > > fix it by replacing pci_alloc_consistent with dma_zalloc_coherent. > > Signed-off-by: YueHaibing > --- > v1->v2: move from pci_dma* to dma_* as Christoph suggested Applied.