Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alvaro.gamez@hazent.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: dp83822: use BMCR_ANENABLE instead of BMSR_ANEGCAPABLE for DP83620
Date: Sun, 10 Jun 2018 12:39:13 -0700 (PDT)	[thread overview]
Message-ID: <20180610.123913.2160801919208192012.davem@davemloft.net> (raw)
In-Reply-To: <20180608102339.2572-1-alvaro.gamez@hazent.com>

From: Alvaro Gamez Machado <alvaro.gamez@hazent.com>
Date: Fri,  8 Jun 2018 12:23:39 +0200

> DP83620 register set is compatible with the DP83848, but it also supports
> 100base-FX. When the hardware is configured such as that fiber mode is
> enabled, autonegotiation is not possible.
> 
> The chip, however, doesn't expose this information via BMSR_ANEGCAPABLE.
> Instead, this bit is always set high, even if the particular hardware
> configuration makes it so that auto negotiation is not possible [1]. Under
> these circumstances, the phy subsystem keeps trying for autonegotiation to
> happen, without success.
> 
> Hereby, we inspect BMCR_ANENABLE bit after genphy_config_init, which on
> reset is set to 0 when auto negotiation is disabled, and so we use this
> value instead of BMSR_ANEGCAPABLE.
> 
> [1] https://e2e.ti.com/support/interface/ethernet/f/903/p/697165/2571170
> 
> Signed-off-by: Alvaro Gamez Machado <alvaro.gamez@hazent.com>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2018-06-10 19:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 10:23 [PATCH] net: phy: dp83822: use BMCR_ANENABLE instead of BMSR_ANEGCAPABLE for DP83620 Alvaro Gamez Machado
2018-06-10 19:39 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180610.123913.2160801919208192012.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alvaro.gamez@hazent.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox