From: David Miller <davem@davemloft.net>
To: dsahern@kernel.org
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH net] net/ipv6: Ensure cfg is properly initialized in ipv6_create_tempaddr
Date: Mon, 11 Jun 2018 16:39:29 -0700 (PDT) [thread overview]
Message-ID: <20180611.163929.1879060173752993644.davem@davemloft.net> (raw)
In-Reply-To: <20180611141212.26371-1-dsahern@kernel.org>
From: dsahern@kernel.org
Date: Mon, 11 Jun 2018 07:12:12 -0700
> From: David Ahern <dsahern@gmail.com>
>
> Valdis reported a BUG in ipv6_add_addr:
...
> Looking at the code I found 1 element (peer_pfx) of the newly introduced
> ifa6_config struct that is not initialized. Use a memset rather than hard
> coding an init for each struct element.
>
> Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Fixes: e6464b8c63619 ("net/ipv6: Convert ipv6_add_addr to struct ifa6_config")
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied, thanks David.
prev parent reply other threads:[~2018-06-11 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 14:12 [PATCH net] net/ipv6: Ensure cfg is properly initialized in ipv6_create_tempaddr dsahern
2018-06-11 23:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611.163929.1879060173752993644.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).