From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net/ipv6: Ensure cfg is properly initialized in ipv6_create_tempaddr Date: Mon, 11 Jun 2018 16:39:29 -0700 (PDT) Message-ID: <20180611.163929.1879060173752993644.davem@davemloft.net> References: <20180611141212.26371-1-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dsahern@gmail.com To: dsahern@kernel.org Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57652 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932471AbeFKXja (ORCPT ); Mon, 11 Jun 2018 19:39:30 -0400 In-Reply-To: <20180611141212.26371-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: dsahern@kernel.org Date: Mon, 11 Jun 2018 07:12:12 -0700 > From: David Ahern > > Valdis reported a BUG in ipv6_add_addr: ... > Looking at the code I found 1 element (peer_pfx) of the newly introduced > ifa6_config struct that is not initialized. Use a memset rather than hard > coding an init for each struct element. > > Reported-by: Valdis Kletnieks > Fixes: e6464b8c63619 ("net/ipv6: Convert ipv6_add_addr to struct ifa6_config") > Signed-off-by: David Ahern Applied, thanks David.