From mboxrd@z Thu Jan 1 00:00:00 1970 From: Taehee Yoo Subject: [PATCH nf-next] netfilter: nft_reject_bridge: remove unnecessary ttl set Date: Tue, 12 Jun 2018 01:35:05 +0900 Message-ID: <20180611163505.9827-1-ap420073@gmail.com> Cc: netdev@vger.kernel.org, Taehee Yoo To: davem@davemloft.net, steffen.klassert@secunet.com Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:43100 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932703AbeFKQfN (ORCPT ); Mon, 11 Jun 2018 12:35:13 -0400 Received: by mail-pg0-f67.google.com with SMTP id a14-v6so9394988pgw.10 for ; Mon, 11 Jun 2018 09:35:13 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: In the nft_reject_br_send_v4_tcp_reset(), a ttl is set by the nf_reject_ip_tcphdr_put(). so, below code is unnecessary. Signed-off-by: Taehee Yoo --- net/bridge/netfilter/nft_reject_bridge.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/netfilter/nft_reject_bridge.c b/net/bridge/netfilter/nft_reject_bridge.c index eaf05de..e0b082c 100644 --- a/net/bridge/netfilter/nft_reject_bridge.c +++ b/net/bridge/netfilter/nft_reject_bridge.c @@ -89,8 +89,7 @@ static void nft_reject_br_send_v4_tcp_reset(struct net *net, niph = nf_reject_iphdr_put(nskb, oldskb, IPPROTO_TCP, net->ipv4.sysctl_ip_default_ttl); nf_reject_ip_tcphdr_put(nskb, oldskb, oth); - niph->ttl = net->ipv4.sysctl_ip_default_ttl; - niph->tot_len = htons(nskb->len); + niph->tot_len = htons(nskb->len); ip_send_check(niph); nft_reject_br_push_etherhdr(oldskb, nskb); -- 2.9.3