From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/1] ip: add rmnet initial support Date: Tue, 12 Jun 2018 17:22:25 -0700 Message-ID: <20180612172225.1c033767@xeon-e3> References: <1528812777-7512-1-git-send-email-dnlplm@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Subash Abhinov Kasiviswanathan To: Daniele Palmas Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:33694 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933126AbeFMAWd (ORCPT ); Tue, 12 Jun 2018 20:22:33 -0400 Received: by mail-pg0-f66.google.com with SMTP id e11-v6so366906pgq.0 for ; Tue, 12 Jun 2018 17:22:32 -0700 (PDT) In-Reply-To: <1528812777-7512-1-git-send-email-dnlplm@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 12 Jun 2018 16:12:57 +0200 Daniele Palmas wrote: > This patch adds basic support for Qualcomm rmnet devices. > > Signed-off-by: Daniele Palmas > --- > ip/Makefile | 2 +- > ip/iplink.c | 2 +- > ip/iplink_rmnet.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 72 insertions(+), 2 deletions(-) > create mode 100644 ip/iplink_rmnet.c }; I am glad to see integrated tool support, but this needs to be targeted at the iproute2-next since it is a new feature. Some things that I would like to see changed: 1. All of iproute2 is now using SPDX license identifiers, you should not include GPL boilerplate 2. You should provide dump (print_opt) as well as parse routine. Output format should use the print_uint (json print) routines. 3. Please update manual page (man/man8/ip-link.8.in) to include the new option.