From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: lucien.xin@gmail.com, edumazet@google.com, netdev@vger.kernel.org
Subject: Re: problems with SCTP GSO
Date: Tue, 12 Jun 2018 14:30:50 -0300 [thread overview]
Message-ID: <20180612173049.GA3732@localhost.localdomain> (raw)
In-Reply-To: <20180612170506.GF3877@localhost.localdomain>
On Tue, Jun 12, 2018 at 02:05:06PM -0300, Marcelo Ricardo Leitner wrote:
> On Mon, Jun 11, 2018 at 08:29:05PM -0700, David Miller wrote:
> >
> > I would like to bring up some problems with the current GSO
> > implementation in SCTP.
> >
> > The most important for me right now is that SCTP uses
> > "skb_gro_receive()" to build "GSO" frames :-(
> >
> > Really it just ends up using the slow path (basically, label 'merge'
> > and onwards).
> >
> > So, using a GRO helper to build GSO packets is not great.
>
> Okay.
>
> >
> > I want to make major surgery here and the only way I can is if
> > it is exactly the GRO demuxing path that uses skb_gro_receive().
> >
> > Those paths pass in the list head from the NAPI struct that initiated
> > the GRO code paths. That makes it easy for me to change this to use a
> > list_head or a hash chain.
> >
> > Probably in the short term SCTP should just have a private helper that
> > builds the frag list, appending 'skb' to 'head'.
> >
> > In the long term, SCTP should use the page frags just like TCP to
> > append the data when building GSO frames. Then it could actually be
> > offloaded and passed into drivers without linearizing.
>
> Sounds like a plan. Shouldn't be too hard to do it.
> (I'm out on PTO, btw)
Xin will work on this, mean while at least. Thanks Xin.
>
> Thanks,
> Marcelo
>
prev parent reply other threads:[~2018-06-12 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 3:29 problems with SCTP GSO David Miller
2018-06-12 17:05 ` Marcelo Ricardo Leitner
2018-06-12 17:30 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612173049.GA3732@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).