From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK Date: Tue, 12 Jun 2018 21:24:01 -0700 Message-ID: <20180612212401.3383c5e4@xeon-e3> References: <1528829293-23222-1-git-send-email-subashab@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Subash Abhinov Kasiviswanathan , netdev@vger.kernel.org, David Ahern , Steffen Klassert To: Lorenzo Colitti Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:33261 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933584AbeFMEYD (ORCPT ); Wed, 13 Jun 2018 00:24:03 -0400 Received: by mail-pl0-f66.google.com with SMTP id 6-v6so196007plb.0 for ; Tue, 12 Jun 2018 21:24:03 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 13 Jun 2018 12:14:53 +0900 Lorenzo Colitti wrote: > On Wed, Jun 13, 2018 at 3:48 AM Subash Abhinov Kasiviswanathan > wrote: > > > > src 192.168.1.1 dst 192.168.1.2 > > proto esp spi 0x00004321 reqid 0 mode tunnel > > replay-window 0 flag af-unspec > > mark 0x10000/0x3ffff > > output-mark 0x20000 > > Nit: I don't know what guarantees we provide (if any) that the output > format of "ip xfrm state" does not change except to add new lines at > the end. Personally, I feel that an app or script that depends on > "auth-trunc" (or anything else, really) being on the line immediately > after "mark" is brittle and should be fixed. This is particularly true > since in general between the mark and the encryption there might be an > auth-trunc line, or an auth line, or neither. As such, adding this > line here seems OK to me. Scripts should use json mode. If it ever gets added to xfrm output (hint).