From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com,
eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames
Date: Wed, 13 Jun 2018 19:05:59 -0700 (PDT) [thread overview]
Message-ID: <20180613.190559.1358933130944096340.davem@davemloft.net> (raw)
In-Reply-To: <20180614004643.GA12409@neilslaptop.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 13 Jun 2018 20:46:43 -0400
> Do you have any performance numbers to compare with and without this
> patch? Adding a function like this implies that any fixes that go
> into skb_gro_receive now need to be evaluated for this function too,
> which means theres an implied overhead in maintaining it. If we're
> signing up for that, I'd like to know that theres a significant
> performance benefit.
Neil, I asked Xin and Marcelo to do this.
There is no reason for GSO code to use a GRO helper.
And this is, in particular, blocking some skb_gro_receive() surgery
I plan to perform.
next prev parent reply other threads:[~2018-06-14 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 23:37 [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames Xin Long
2018-06-13 23:42 ` Marcelo Ricardo Leitner
2018-06-14 0:46 ` Neil Horman
2018-06-14 1:21 ` Xin Long
2018-06-14 11:35 ` Neil Horman
2018-06-14 2:05 ` David Miller [this message]
2018-06-14 11:36 ` Neil Horman
2018-06-14 17:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613.190559.1358933130944096340.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).