From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] sctp: define sctp_packet_gso_append to build GSO frames Date: Thu, 14 Jun 2018 10:26:19 -0700 (PDT) Message-ID: <20180614.102619.1396652025539374413.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com, eric.dumazet@gmail.com To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45750 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754526AbeFNR0U (ORCPT ); Thu, 14 Jun 2018 13:26:20 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Thu, 14 Jun 2018 07:37:02 +0800 > Now sctp GSO uses skb_gro_receive() to append the data into head > skb frag_list. However it actually only needs very few code from > skb_gro_receive(). Besides, NAPI_GRO_CB has to be set while most > of its members are not needed here. > > This patch is to add sctp_packet_gso_append() to build GSO frames > instead of skb_gro_receive(), and it would avoid many unnecessary > checks and make the code clearer. > > Note that sctp will use page frags instead of frag_list to build > GSO frames in another patch. But it may take time, as sctp's GSO > frames may have different size. skb_segment() can only split it > into the frags with the same size, which would break the border > of sctp chunks. > > Signed-off-by: Xin Long Applied to 'net', thanks Xin.