From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver Date: Thu, 14 Jun 2018 13:30:28 +0200 Message-ID: <20180614113028.GB2518@nanopsycho.orion> References: <1528974690-31600-1-git-send-email-ilias.apalodimas@linaro.org> <1528974690-31600-5-git-send-email-ilias.apalodimas@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, grygorii.strashko@ti.com, ivan.khoronzhuk@linaro.org, nsekhar@ti.com, ivecera@redhat.com, andrew@lunn.ch, f.fainelli@gmail.com, francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com, Jose.Abreu@synopsys.com To: Ilias Apalodimas Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:42979 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754893AbeFNLba (ORCPT ); Thu, 14 Jun 2018 07:31:30 -0400 Received: by mail-wr0-f196.google.com with SMTP id w10-v6so6039408wrk.9 for ; Thu, 14 Jun 2018 04:31:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1528974690-31600-5-git-send-email-ilias.apalodimas@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Jun 14, 2018 at 01:11:30PM CEST, ilias.apalodimas@linaro.org wrote: [...] >@@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data, > if (of_property_read_bool(node, "dual_emac")) > data->switch_mode = CPSW_DUAL_EMAC; > >+ /* switchdev overrides DTS */ >+ if (IS_ENABLED(CONFIG_TI_CPSW_SWITCHDEV)) >+ data->switch_mode = CPSW_SWITCHDEV; So you force CPSW_SWITCHDEV mode if the CONFIG_TI_CPSW_SWITCHDEV is enabled. That does not sound right. I think that user should tell what mode does he want regardless what the kernel config is.