From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, grygorii.strashko@ti.com,
ivan.khoronzhuk@linaro.org, nsekhar@ti.com, ivecera@redhat.com,
andrew@lunn.ch, f.fainelli@gmail.com, francois.ozog@linaro.org,
yogeshs@ti.com, spatton@ti.com, Jose.Abreu@synopsys.com
Subject: Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver
Date: Thu, 14 Jun 2018 14:34:04 +0300 [thread overview]
Message-ID: <20180614113404.GB32505@apalos> (raw)
In-Reply-To: <20180614113028.GB2518@nanopsycho.orion>
On Thu, Jun 14, 2018 at 01:30:28PM +0200, Jiri Pirko wrote:
> Thu, Jun 14, 2018 at 01:11:30PM CEST, ilias.apalodimas@linaro.org wrote:
>
> [...]
>
> >@@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
> > if (of_property_read_bool(node, "dual_emac"))
> > data->switch_mode = CPSW_DUAL_EMAC;
> >
> >+ /* switchdev overrides DTS */
> >+ if (IS_ENABLED(CONFIG_TI_CPSW_SWITCHDEV))
> >+ data->switch_mode = CPSW_SWITCHDEV;
>
> So you force CPSW_SWITCHDEV mode if the CONFIG_TI_CPSW_SWITCHDEV is
> enabled. That does not sound right. I think that user should tell what
> mode does he want regardless what the kernel config is.
We discussed this during the V1 of the RFC. Yes it doesn't seem good, but the
device currently configures the modes using DTS (which is not correct). I choose
the .config due to that. I can't think of anything better, but i am open to
suggestions
next prev parent reply other threads:[~2018-06-14 11:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 11:11 [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 1/4] net/cpsw: move common headers definitions to cpsw_priv.h Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 2/4] net/cpsw_ale: add functions to modify VLANs/MDBs Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 3/4] net/cpsw: prepare cpsw for switchdev support Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver Ilias Apalodimas
2018-06-14 11:23 ` Jiri Pirko
2018-06-14 11:32 ` Ilias Apalodimas
2018-06-14 11:30 ` Jiri Pirko
2018-06-14 11:34 ` Ilias Apalodimas [this message]
2018-06-14 11:39 ` Jiri Pirko
2018-06-14 11:43 ` Ilias Apalodimas
2018-06-18 23:19 ` Grygorii Strashko
2018-06-20 7:08 ` Jiri Pirko
2018-06-20 12:53 ` Ivan Vecera
2018-06-20 12:59 ` Ilias Apalodimas
2018-06-20 13:54 ` Ivan Vecera
2018-06-18 16:16 ` Andrew Lunn
2018-06-18 20:19 ` Ilias Apalodimas
2018-06-18 23:20 ` Grygorii Strashko
2018-06-20 12:56 ` Ivan Vecera
2018-06-20 17:51 ` Ilias Apalodimas
2018-06-20 17:57 ` Andrew Lunn
2018-06-20 17:58 ` Florian Fainelli
2018-06-20 18:03 ` Ilias Apalodimas
2018-06-21 12:19 ` Ivan Vecera
2018-06-21 12:45 ` Ilias Apalodimas
2018-06-21 15:31 ` Arnd Bergmann
2018-06-22 7:45 ` Ilias Apalodimas
2018-06-27 19:18 ` Grygorii Strashko
2018-06-27 20:40 ` Arnd Bergmann
2018-06-27 23:03 ` Grygorii Strashko
2018-06-28 7:53 ` Arnd Bergmann
2018-06-18 15:04 ` [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW Andrew Lunn
2018-06-18 16:04 ` Ilias Apalodimas
2018-06-18 16:28 ` Andrew Lunn
2018-06-18 16:46 ` Ilias Apalodimas
2018-06-18 17:30 ` Andrew Lunn
2018-06-18 17:49 ` Ilias Apalodimas
2018-06-27 21:05 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614113404.GB32505@apalos \
--to=ilias.apalodimas@linaro.org \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=francois.ozog@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=spatton@ti.com \
--cc=yogeshs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).