From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilias Apalodimas Subject: Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver Date: Thu, 14 Jun 2018 14:43:00 +0300 Message-ID: <20180614114300.GA416@apalos> References: <1528974690-31600-1-git-send-email-ilias.apalodimas@linaro.org> <1528974690-31600-5-git-send-email-ilias.apalodimas@linaro.org> <20180614113028.GB2518@nanopsycho.orion> <20180614113404.GB32505@apalos> <20180614113958.GC2518@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, grygorii.strashko@ti.com, ivan.khoronzhuk@linaro.org, nsekhar@ti.com, ivecera@redhat.com, andrew@lunn.ch, f.fainelli@gmail.com, francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com, Jose.Abreu@synopsys.com To: unlisted-recipients:; (no To-header on input) Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:53362 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754893AbeFNLnF (ORCPT ); Thu, 14 Jun 2018 07:43:05 -0400 Received: by mail-wm0-f66.google.com with SMTP id x6-v6so9967044wmc.3 for ; Thu, 14 Jun 2018 04:43:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180614113958.GC2518@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jun 14, 2018 at 01:39:58PM +0200, Jiri Pirko wrote: > Thu, Jun 14, 2018 at 01:34:04PM CEST, ilias.apalodimas@linaro.org wrote: > >On Thu, Jun 14, 2018 at 01:30:28PM +0200, Jiri Pirko wrote: > >> Thu, Jun 14, 2018 at 01:11:30PM CEST, ilias.apalodimas@linaro.org wrote: > >> > >> [...] > >> > >> >@@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data, > >> > if (of_property_read_bool(node, "dual_emac")) > >> > data->switch_mode = CPSW_DUAL_EMAC; > >> > > >> >+ /* switchdev overrides DTS */ > >> >+ if (IS_ENABLED(CONFIG_TI_CPSW_SWITCHDEV)) > >> >+ data->switch_mode = CPSW_SWITCHDEV; > >> > >> So you force CPSW_SWITCHDEV mode if the CONFIG_TI_CPSW_SWITCHDEV is > >> enabled. That does not sound right. I think that user should tell what > >> mode does he want regardless what the kernel config is. > >We discussed this during the V1 of the RFC. Yes it doesn't seem good, but the > >device currently configures the modes using DTS (which is not correct). I choose > >the .config due to that. I can't think of anything better, but i am open to > >suggestions > > Agreed that DTS does fit as well. I think that this might be a job for > devlink parameters (patchset is going to be sent upstream next week). > You do have 1 bus address for the whole device (both ports), right? > Yes devlink sounds reasonable. I thyink there's only one bus for it, but then again i am far from an expert on the hardware interrnals. Grygorii can correct me if i am wrong. Thanks for taking time to read this, Ilias