From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tejaswi Tanikella <tejaswit@codeaurora.org>
Subject: Re: [PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed
 reports
Date: Thu, 14 Jun 2018 18:44:15 +0530
Message-ID: <20180614131411.GA7507@tejaswit-linux.qualcomm.com>
References: <20180611115058.GA12452@tejaswit-linux.qualcomm.com>
 <20180612162818.GA12251@lunn.ch>
 <20180613133256.GA20232@tejaswit-linux.qualcomm.com>
 <20180613144437.GA31647@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, davem@davemloft.net
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:33734 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754912AbeFNNOX (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 14 Jun 2018 09:14:23 -0400
Content-Disposition: inline
In-Reply-To: <20180613144437.GA31647@lunn.ch>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Jun 13, 2018 at 04:44:37PM +0200, Andrew Lunn wrote:
> While it has been asleep, it has also been dropping any multicast
> traffic in the stream. So it does not really matter it has left the
> group. You were not receiving the packets anyway.
> 
> Thing about this from another angle. I have an NTP client running on
> my laptop, using multicast address 224.0.1.1. I suspend my laptop and
> walk away for two hours. When i come back, i find that 20 seconds
> after i suspended it, it resumed and send an group response
> message. And an hour later, since it was still running, the battery
> went flat.
> 
> It seems to me, the change you are proposing cannot be the default
> behaviour.
> 
> I actually think you need to be looking at some sort of WoL feature.
> You need the multicast stream data packets to wake you, and you also
> need to wake up the IGMP query message. And you need to wake up to
> send the group membership. Does your hardware have this sort of WoL
> support? You can then explicitly enable this WoL for your application.
> 
> 	Andrew

Thanks Andrew.
You are right, this should not be the default behaviour.

-Tejaswi