From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 0/2] l2tp: l2tp_ppp must ignore non-PPP sessions Date: Fri, 15 Jun 2018 09:12:51 -0700 (PDT) Message-ID: <20180615.091251.2078462924953448784.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jchapman@katalix.com To: g.nault@alphalink.fr Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:59526 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964779AbeFOQMw (ORCPT ); Fri, 15 Jun 2018 12:12:52 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Guillaume Nault Date: Fri, 15 Jun 2018 15:39:15 +0200 > The original L2TP code was written for version 2 of the protocol, which > could only carry PPP sessions. Then L2TPv3 generalised the protocol so that > it could transport different kinds of pseudo-wires. But parts of the > l2tp_ppp module still break in presence of non-PPP sessions. > > Assuming L2TPv2 tunnels can only transport PPP sessions is right, but > l2tp_netlink failed to ensure that (fixed in patch 1). > When retrieving a session from an arbitrary tunnel, l2tp_ppp needs to > filter out non-PPP sessions (last occurrence fixed in patch 2). Series applied, thank you.