From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@redhat.com>
Subject: Re: [PATCH net] net: stmmac: Run HWIF Quirks after getting HW caps
Date: Fri, 15 Jun 2018 09:39:30 -0700 (PDT)
Message-ID: <20180615.093930.903069013183178596.davem@redhat.com>
References: <dfed3e3682f8dcf2285e8029fa13803a89dfc55e.1529075731.git.joabreu@synopsys.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Joao.Pinto@synopsys.com,
        Vitor.Soares@synopsys.com, peppe.cavallaro@st.com,
        alexandre.torgue@st.com, dinh.linux@gmail.com
To: Jose.Abreu@synopsys.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38396 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S966037AbeFOQjd (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 15 Jun 2018 12:39:33 -0400
In-Reply-To: <dfed3e3682f8dcf2285e8029fa13803a89dfc55e.1529075731.git.joabreu@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Fri, 15 Jun 2018 16:17:27 +0100

> Currently we were running HWIF quirks before getting HW capabilities.
> This is not right because some HWIF callbacks depend on HW caps.
> 
> Lets save the quirks callback and use it in a later stage.
> 
> This fixes Altera socfpga.
> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Fixes: 5f0456b43140 ("net: stmmac: Implement logic to automatically select HW Interface")
> Reported-by: Dinh Nguyen <dinh.linux@gmail.com>

Applied, thanks for fixing this.