From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 v3] ipaddress: strengthen check on 'label' input Date: Fri, 15 Jun 2018 11:19:11 -0700 Message-ID: <20180615111911.75d1437b@xeon-e3> References: <1528984017-19490-1-git-send-email-ptalbert@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Patrick Talbert Return-path: Received: from mail-pl0-f45.google.com ([209.85.160.45]:38006 "EHLO mail-pl0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755493AbeFOSTO (ORCPT ); Fri, 15 Jun 2018 14:19:14 -0400 Received: by mail-pl0-f45.google.com with SMTP id b14-v6so5747872pls.5 for ; Fri, 15 Jun 2018 11:19:14 -0700 (PDT) In-Reply-To: <1528984017-19490-1-git-send-email-ptalbert@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 14 Jun 2018 15:46:57 +0200 Patrick Talbert wrote: > As mentioned in the ip-address man page, an address label must > be equal to the device name or prefixed by the device name > followed by a colon. Currently the only check on this input is > to see if the device name appears at the beginning of the label > string. > > This commit adds an additional check to ensure label == dev or > continues with a colon. > > Signed-off-by: Patrick Talbert > Suggested-by: Stephen Hemminger Sure applied