From mboxrd@z Thu Jan 1 00:00:00 1970 From: efremov@linux.com Subject: [PATCH] xfrm4: Remove export declaration from xfrm4_protocol_init Date: Sat, 16 Jun 2018 23:58:40 +0300 Message-ID: <20180616205840.19822-1-efremov@linux.com> Cc: Denis Efremov , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org To: Steffen Klassert Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Denis Efremov The function xfrm4_protocol_init is exported as GPL symbol and annotated as __init. That is reasonable only in the case when this function is called from another's module __init section. Otherwise, we will face section mismatch error. xfrm4_protocol_init is used in xfrm4_init along with xfrm4_state_init and xfrm4_policy_init. The last two functions are not exported as GPL symbols. According to this, it seem's like there is no reason to export xfrm4_protocol_init too. Fix potential section mismatch by removing export declaration from xfrm4_protocol_init. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov --- net/ipv4/xfrm4_protocol.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv4/xfrm4_protocol.c b/net/ipv4/xfrm4_protocol.c index 8dd0e6ab8606..0e1f5dc2766b 100644 --- a/net/ipv4/xfrm4_protocol.c +++ b/net/ipv4/xfrm4_protocol.c @@ -297,4 +297,3 @@ void __init xfrm4_protocol_init(void) { xfrm_input_register_afinfo(&xfrm4_input_afinfo); } -EXPORT_SYMBOL(xfrm4_protocol_init); -- 2.17.1