From: Andrew Lunn <andrew@lunn.ch>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: netdev@vger.kernel.org, grygorii.strashko@ti.com,
ivan.khoronzhuk@linaro.org, nsekhar@ti.com, jiri@resnulli.us,
ivecera@redhat.com, f.fainelli@gmail.com,
francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com,
Jose.Abreu@synopsys.com
Subject: Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver
Date: Mon, 18 Jun 2018 18:16:27 +0200 [thread overview]
Message-ID: <20180618161627.GC5865@lunn.ch> (raw)
In-Reply-To: <1528974690-31600-5-git-send-email-ilias.apalodimas@linaro.org>
> @@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
> if (of_property_read_bool(node, "dual_emac"))
> data->switch_mode = CPSW_DUAL_EMAC;
>
> + /* switchdev overrides DTS */
> + if (IS_ENABLED(CONFIG_TI_CPSW_SWITCHDEV))
> + data->switch_mode = CPSW_SWITCHDEV;
> +
I know you discussed this a bit with Jiri, but i still think if
'dual_mac" is found, you should do dual mac. The DT clearly requests
dual mac, and doing anything else is going to cause confusion.
The device tree binding is ambiguous what should happen when dual-mac
is missing. So i would only enable swithdev mode in that case.
But ideally, it should be a new driver with a new binding.
Andrew
next prev parent reply other threads:[~2018-06-18 16:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 11:11 [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 1/4] net/cpsw: move common headers definitions to cpsw_priv.h Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 2/4] net/cpsw_ale: add functions to modify VLANs/MDBs Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 3/4] net/cpsw: prepare cpsw for switchdev support Ilias Apalodimas
2018-06-14 11:11 ` [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver Ilias Apalodimas
2018-06-14 11:23 ` Jiri Pirko
2018-06-14 11:32 ` Ilias Apalodimas
2018-06-14 11:30 ` Jiri Pirko
2018-06-14 11:34 ` Ilias Apalodimas
2018-06-14 11:39 ` Jiri Pirko
2018-06-14 11:43 ` Ilias Apalodimas
2018-06-18 23:19 ` Grygorii Strashko
2018-06-20 7:08 ` Jiri Pirko
2018-06-20 12:53 ` Ivan Vecera
2018-06-20 12:59 ` Ilias Apalodimas
2018-06-20 13:54 ` Ivan Vecera
2018-06-18 16:16 ` Andrew Lunn [this message]
2018-06-18 20:19 ` Ilias Apalodimas
2018-06-18 23:20 ` Grygorii Strashko
2018-06-20 12:56 ` Ivan Vecera
2018-06-20 17:51 ` Ilias Apalodimas
2018-06-20 17:57 ` Andrew Lunn
2018-06-20 17:58 ` Florian Fainelli
2018-06-20 18:03 ` Ilias Apalodimas
2018-06-21 12:19 ` Ivan Vecera
2018-06-21 12:45 ` Ilias Apalodimas
2018-06-21 15:31 ` Arnd Bergmann
2018-06-22 7:45 ` Ilias Apalodimas
2018-06-27 19:18 ` Grygorii Strashko
2018-06-27 20:40 ` Arnd Bergmann
2018-06-27 23:03 ` Grygorii Strashko
2018-06-28 7:53 ` Arnd Bergmann
2018-06-18 15:04 ` [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW Andrew Lunn
2018-06-18 16:04 ` Ilias Apalodimas
2018-06-18 16:28 ` Andrew Lunn
2018-06-18 16:46 ` Ilias Apalodimas
2018-06-18 17:30 ` Andrew Lunn
2018-06-18 17:49 ` Ilias Apalodimas
2018-06-27 21:05 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618161627.GC5865@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jose.Abreu@synopsys.com \
--cc=f.fainelli@gmail.com \
--cc=francois.ozog@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=spatton@ti.com \
--cc=yogeshs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).