From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH rdma-next v2 00/20] Introduce mlx5 DEVX interface Date: Tue, 19 Jun 2018 07:59:30 +0300 Message-ID: <20180619045930.GA7557@mtr-leonro.mtl.com> References: <20180617100006.30663-1-leon@kernel.org> <20180618220504.GH6805@ziepe.ca> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Cc: Doug Ledford , RDMA mailing list , Joonas Lahtinen , Matan Barak , Yishai Hadas , Saeed Mahameed , linux-netdev To: Jason Gunthorpe Return-path: Received: from mail.kernel.org ([198.145.29.99]:43598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbeFSE7e (ORCPT ); Tue, 19 Jun 2018 00:59:34 -0400 Content-Disposition: inline In-Reply-To: <20180618220504.GH6805@ziepe.ca> Sender: netdev-owner@vger.kernel.org List-ID: --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 18, 2018 at 04:05:04PM -0600, Jason Gunthorpe wrote: > On Sun, Jun 17, 2018 at 12:59:46PM +0300, Leon Romanovsky wrote: > > > Leon Romanovsky (2): > > drm/i915: Move u64-to-ptr helpers to general header > > kernel.h: Reuse u64_to_ptr macro to cast __user pointers > > I dropped these since they are not needed by this series when using a > union. No problem, it was my idea to reuse existing macro, before it was hard-coded implementation, but union makes it cleaner. > > > Matan Barak (5): > > IB/uverbs: Export uverbs idr and fd types > > IB/uverbs: Add PTR_IN attributes that are allocated/copied > > automatically > > Revised this one, as noted Thanks > > > IB/uverbs: Add a macro to define a type with no kernel known size > > IB/uverbs: Allow an empty namespace in ioctl() framework > > IB/uverbs: Refactor uverbs_finalize_objects > > I put the above in a branch and can apply them if you ack my revisions.. > Except the line "return (void *)attr;", which should be "return ERR_CAST(attr);" everything looks reasonable. I didn't test it, but I'm not worried, we will have enough time to fix if needed. > > net/mlx5_core: Prevent warns in dmesg upon firmware commands > > IB/core: Improve uverbs_cleanup_ucontext algorithm > > I dropped these two (they are linked), need comments addressed and > resent. They are linked only logically, the second patch will trigger warning which is suppressed by first patch. So actually mlx5-net branch will have only first patch "net/mlx5_core: Prevent warns in dmesg upon firmware commands" and you will apply "IB/core: Improve uverbs_cleanup_ucontext algorithm" in your rdma-next. > > > Yishai Hadas (13): > > net/mlx5: Expose DEVX ifc structures > > IB/mlx5: Introduce DEVX > > IB/core: Introduce DECLARE_UVERBS_GLOBAL_METHODS > > IB: Expose ib_ucontext from a given ib_uverbs_file > > IB/mlx5: Add support for DEVX general command > > IB/mlx5: Add obj create and destroy functionality > > IB/mlx5: Add DEVX support for modify and query commands > > IB/mlx5: Add support for DEVX query UAR > > IB/mlx5: Add DEVX support for memory registration > > IB/mlx5: Add DEVX query EQN support > > IB/mlx5: Expose DEVX tree > > I put these in a branch also and can apply them, but I need the first > two patches in the mlx5 core branch first please, thanks. > > Since this requires so many core patches I think I prefer to merge the > mlx core branch then apply rather merge a branch. So to summarize, I'm applying those three patches to mlx5-next: * net/mlx5_core: Prevent warns in dmesg upon firmware commands * net/mlx5: Expose DEVX ifc structures * IB/mlx5: Introduce DEVX And resend: * IB/core: Improve uverbs_cleanup_ucontext algorithm Thanks > > Jason --FCuugMFkClbJLl1L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJbKI2yAAoJEORje4g2clinlocP/RWAOeC3vd12hOo7t8Pj393X C2WXtVDyvKb8+EAYVac/8KIJlJm+wF0P20zvV9JunHmmyszjdEN4YgVYeggXPW31 BeKq94odU7P225pwZ9TDoglxf5eYvsWRuNKOVnKyoSvsr3ucxwVSRvl9L2d09+08 qoiayllHeIVw3wft5QMpXYsKCKGlwtZoFW1cis5ZPM8m5Pec2Mt0ORVgJDWA3jxR 3h75sUhiqkJWygZMKggxHJKkMKZDXvhR1QITr+goSdRYH38SpdhEmCzrawcyr+NY ANnawvl1TqoVYFBA7rfZfgkOEmYFaKJAmIWGsOBH6wc2ZnraUvlXiZSZL0ouzGEj 9YqcOKMMOkvOT8ep8hhF2PB5pndlppwXokftUaDQ7QmIhK1/2urEnSZAIYsiXQPr HdOX5Vv6d87Y+iURD2VA7DHYpwXPXfopeWFHejp1H74+1HwcwNfR/DHwnm5o5avR BKPVQefqsL5leAJ0dR5si6bU+AZTRlXU6ev4koAnX/EKL4XpuzElX4C+KtQ+nt0N c/v3VgGDobu2h/m2gLKLxm63T9322xz2PcSCEEaC5TKJZyWYQbxFuaT/x230ttw8 tNiVT2eEzHhWNwJaVluNQYrxZokqPfuSfzA89Jlw0voLJnOBbJHoLFqTvt2SNZ+d N39oCV6vj+gzXyKsZ4Bp =ccnC -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L--