From: Florian Westphal <fw@strlen.de>
To: Li RongQing <lirongqing@baidu.com>
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com
Subject: Re: [PATCH][v2] xfrm: replace NR_CPU with nr_cpu_ids
Date: Tue, 19 Jun 2018 09:53:49 +0200 [thread overview]
Message-ID: <20180619075349.sgs7xr7aafcdcfcy@breakpoint.cc> (raw)
In-Reply-To: <1529392300-8298-1-git-send-email-lirongqing@baidu.com>
Li RongQing <lirongqing@baidu.com> wrote:
> The default NR_CPUS can be very large, but actual possible nr_cpu_ids
> usually is very small. For some x86 distribution, the NR_CPUS is 8192
> and nr_cpu_ids is 4, so replace NR_CPU to save some memory
Steffen,
I will soon submit a patch to remove the percpu cache; removal
improved performance for at least one user (and by quite a sizeable
amount).
Would you consider such removal for ipsec or ipsec-next?
If -next, consider applying this patch for ipsec.git.
Otherwise consider not applying this, as the code will go away soon.
Thanks,
Florian
next prev parent reply other threads:[~2018-06-19 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 7:11 [PATCH][v2] xfrm: replace NR_CPU with nr_cpu_ids Li RongQing
2018-06-19 7:48 ` Yunsheng Lin
2018-06-19 7:53 ` Florian Westphal [this message]
2018-06-19 12:17 ` Steffen Klassert
2018-06-20 9:55 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619075349.sgs7xr7aafcdcfcy@breakpoint.cc \
--to=fw@strlen.de \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox