From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH][v2] xfrm: replace NR_CPU with nr_cpu_ids Date: Tue, 19 Jun 2018 09:53:49 +0200 Message-ID: <20180619075349.sgs7xr7aafcdcfcy@breakpoint.cc> References: <1529392300-8298-1-git-send-email-lirongqing@baidu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com To: Li RongQing Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:33508 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937236AbeFSHxy (ORCPT ); Tue, 19 Jun 2018 03:53:54 -0400 Content-Disposition: inline In-Reply-To: <1529392300-8298-1-git-send-email-lirongqing@baidu.com> Sender: netdev-owner@vger.kernel.org List-ID: Li RongQing wrote: > The default NR_CPUS can be very large, but actual possible nr_cpu_ids > usually is very small. For some x86 distribution, the NR_CPUS is 8192 > and nr_cpu_ids is 4, so replace NR_CPU to save some memory Steffen, I will soon submit a patch to remove the percpu cache; removal improved performance for at least one user (and by quite a sizeable amount). Would you consider such removal for ipsec or ipsec-next? If -next, consider applying this patch for ipsec.git. Otherwise consider not applying this, as the code will go away soon. Thanks, Florian