From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Mashak <mrv@mojatatu.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action
Date: Tue, 19 Jun 2018 10:04:08 -0700 [thread overview]
Message-ID: <20180619100408.42155193@xeon-e3> (raw)
In-Reply-To: <1529427368-17129-6-git-send-email-mrv@mojatatu.com>
On Tue, 19 Jun 2018 12:56:08 -0400
Roman Mashak <mrv@mojatatu.com> wrote:
> Change "tc filter pedit .." to "tc actions pedit .." in error
> messages to clearly refer to pedit action.
>
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> ---
> net/sched/act_pedit.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
> index 3b775f54cee5..caa6927a992c 100644
> --- a/net/sched/act_pedit.c
> +++ b/net/sched/act_pedit.c
> @@ -305,7 +305,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
>
> rc = pedit_skb_hdr_offset(skb, htype, &hoffset);
> if (rc) {
> - pr_info("tc filter pedit bad header type specified (0x%x)\n",
> + pr_info("tc action pedit bad header type specified (0x%x)\n",
> htype);
> goto bad;
> }
> @@ -314,7 +314,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
> char *d, _d;
>
> if (!offset_valid(skb, hoffset + tkey->at)) {
> - pr_info("tc filter pedit 'at' offset %d out of bounds\n",
> + pr_info("tc action pedit 'at' offset %d out of bounds\n",
> hoffset + tkey->at);
> goto bad;
> }
> @@ -326,12 +326,12 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
> }
>
> if (offset % 4) {
> - pr_info("tc filter pedit offset must be on 32 bit boundaries\n");
> + pr_info("tc action pedit offset must be on 32 bit boundaries\n");
> goto bad;
> }
>
> if (!offset_valid(skb, hoffset + offset)) {
> - pr_info("tc filter pedit offset %d out of bounds\n",
> + pr_info("tc action pedit offset %d out of bounds\n",
> hoffset + offset);
> goto bad;
Time to convert these to netlink extack reporting?
next prev parent reply other threads:[~2018-06-19 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:56 [PATCH net 0/5] net sched actions: code style cleanup and fixes Roman Mashak
2018-06-19 16:56 ` [PATCH net 1/5] net sched actions: fix coding style in pedit action Roman Mashak
2018-06-20 12:29 ` Davide Caratti
2018-06-20 13:25 ` Roman Mashak
2018-06-19 16:56 ` [PATCH net 2/5] net sched actions: fix coding style in pedit headers Roman Mashak
2018-06-19 16:56 ` [PATCH net 3/5] net sched actions: fix sparse warning Roman Mashak
2018-06-19 16:56 ` [PATCH net 4/5] net sched actions: use sizeof operator for buffer length Roman Mashak
2018-06-19 16:56 ` [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action Roman Mashak
2018-06-19 17:04 ` Stephen Hemminger [this message]
2018-06-19 17:15 ` Roman Mashak
2018-06-20 8:20 ` [PATCH net 0/5] net sched actions: code style cleanup and fixes Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619100408.42155193@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).