From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action Date: Tue, 19 Jun 2018 10:04:08 -0700 Message-ID: <20180619100408.42155193@xeon-e3> References: <1529427368-17129-1-git-send-email-mrv@mojatatu.com> <1529427368-17129-6-git-send-email-mrv@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: Roman Mashak Return-path: Received: from mail-pl0-f43.google.com ([209.85.160.43]:37823 "EHLO mail-pl0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966649AbeFSRET (ORCPT ); Tue, 19 Jun 2018 13:04:19 -0400 Received: by mail-pl0-f43.google.com with SMTP id 31-v6so178099plc.4 for ; Tue, 19 Jun 2018 10:04:19 -0700 (PDT) In-Reply-To: <1529427368-17129-6-git-send-email-mrv@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 19 Jun 2018 12:56:08 -0400 Roman Mashak wrote: > Change "tc filter pedit .." to "tc actions pedit .." in error > messages to clearly refer to pedit action. > > Signed-off-by: Roman Mashak > --- > net/sched/act_pedit.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c > index 3b775f54cee5..caa6927a992c 100644 > --- a/net/sched/act_pedit.c > +++ b/net/sched/act_pedit.c > @@ -305,7 +305,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, > > rc = pedit_skb_hdr_offset(skb, htype, &hoffset); > if (rc) { > - pr_info("tc filter pedit bad header type specified (0x%x)\n", > + pr_info("tc action pedit bad header type specified (0x%x)\n", > htype); > goto bad; > } > @@ -314,7 +314,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, > char *d, _d; > > if (!offset_valid(skb, hoffset + tkey->at)) { > - pr_info("tc filter pedit 'at' offset %d out of bounds\n", > + pr_info("tc action pedit 'at' offset %d out of bounds\n", > hoffset + tkey->at); > goto bad; > } > @@ -326,12 +326,12 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, > } > > if (offset % 4) { > - pr_info("tc filter pedit offset must be on 32 bit boundaries\n"); > + pr_info("tc action pedit offset must be on 32 bit boundaries\n"); > goto bad; > } > > if (!offset_valid(skb, hoffset + offset)) { > - pr_info("tc filter pedit offset %d out of bounds\n", > + pr_info("tc action pedit offset %d out of bounds\n", > hoffset + offset); > goto bad; Time to convert these to netlink extack reporting?