From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor
 struct
Date: Wed, 20 Jun 2018 07:37:50 +0900 (KST)
Message-ID: <20180620.073750.642289685695664600.davem@davemloft.net>
References: <20180619165453.31894-1-mdf@kernel.org>
        <832bebb8-300d-e911-2946-5edfe82dc30a@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: mdf@kernel.org, keescook@chromium.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: f.fainelli@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:49050 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753832AbeFSWhx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 19 Jun 2018 18:37:53 -0400
In-Reply-To: <832bebb8-300d-e911-2946-5edfe82dc30a@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 19 Jun 2018 10:13:55 -0700

> How could padding be inserted given than all of the structure members
> are naturally aligned (all u32 type). Compiler bug?

Agreed, this looks completely unnecessary.

__packed should only be used when absolutely necessary because using
it generates less efficient code on some architectures.