From: David Miller <davem@davemloft.net>
To: gvaradar@cisco.com
Cc: benve@cisco.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] enic: initialize enic->rfs_h.lock in enic_probe
Date: Wed, 20 Jun 2018 07:49:58 +0900 (KST) [thread overview]
Message-ID: <20180620.074958.941077810963592489.davem@davemloft.net> (raw)
In-Reply-To: <20180619151524.1326-1-gvaradar@cisco.com>
From: Govindarajulu Varadarajan <gvaradar@cisco.com>
Date: Tue, 19 Jun 2018 08:15:24 -0700
> lockdep spotted that we are using rfs_h.lock in enic_get_rxnfc() without
> initializing. rfs_h.lock is initialized in enic_open(). But ethtool_ops
> can be called when interface is down.
>
> Move enic_rfs_flw_tbl_init to enic_probe.
...
> Signed-off-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
Applied, thanks.
prev parent reply other threads:[~2018-06-19 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 15:15 [PATCH net] enic: initialize enic->rfs_h.lock in enic_probe Govindarajulu Varadarajan
2018-06-19 22:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620.074958.941077810963592489.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benve@cisco.com \
--cc=gvaradar@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).