From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] enic: initialize enic->rfs_h.lock in enic_probe Date: Wed, 20 Jun 2018 07:49:58 +0900 (KST) Message-ID: <20180620.074958.941077810963592489.davem@davemloft.net> References: <20180619151524.1326-1-gvaradar@cisco.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: benve@cisco.com, netdev@vger.kernel.org To: gvaradar@cisco.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:49192 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbeFSWuB (ORCPT ); Tue, 19 Jun 2018 18:50:01 -0400 In-Reply-To: <20180619151524.1326-1-gvaradar@cisco.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Govindarajulu Varadarajan Date: Tue, 19 Jun 2018 08:15:24 -0700 > lockdep spotted that we are using rfs_h.lock in enic_get_rxnfc() without > initializing. rfs_h.lock is initialized in enic_open(). But ethtool_ops > can be called when interface is down. > > Move enic_rfs_flw_tbl_init to enic_probe. ... > Signed-off-by: Govindarajulu Varadarajan Applied, thanks.