From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net/sched: act_ife: preserve the action control in case of error Date: Wed, 20 Jun 2018 09:06:54 +0900 (KST) Message-ID: <20180620.090654.1172856601847757830.davem@davemloft.net> References: <717d0682de4fb24ed6818f2bf264202d22e1e8be.1529415179.git.dcaratti@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org To: dcaratti@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:50698 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbeFTAG4 (ORCPT ); Tue, 19 Jun 2018 20:06:56 -0400 In-Reply-To: <717d0682de4fb24ed6818f2bf264202d22e1e8be.1529415179.git.dcaratti@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Davide Caratti Date: Tue, 19 Jun 2018 15:45:50 +0200 > in the following script > > # tc actions add action ife encode allow prio pass index 42 > # tc actions replace action ife encode allow tcindex drop index 42 > > the action control should remain equal to 'pass', if the kernel failed > to replace the TC action. Pospone the assignment of the action control, > to ensure it is not overwritten in the error path of tcf_ife_init(). > > Fixes: ef6980b6becb ("introduce IFE action") > Signed-off-by: Davide Caratti Applied and queued up for -stable.