From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net/usb/drivers: Remove useless hrtimer_active check Date: Wed, 20 Jun 2018 09:07:04 +0900 (KST) Message-ID: <20180620.090704.1841351400456293204.davem@davemloft.net> References: <1529417671-21384-1-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: oliver@neukum.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: daniel.lezcano@linaro.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:50724 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753486AbeFTAHH (ORCPT ); Tue, 19 Jun 2018 20:07:07 -0400 In-Reply-To: <1529417671-21384-1-git-send-email-daniel.lezcano@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Daniel Lezcano Date: Tue, 19 Jun 2018 16:14:30 +0200 > The code does: > > if (hrtimer_active(&t)) > hrtimer_cancel(&t); > > However, hrtimer_cancel() checks if the timer is active, so the > test above is pointless. > > Signed-off-by: Daniel Lezcano Applied.