From: David Miller <davem@davemloft.net>
To: mdf@kernel.org
Cc: keescook@chromium.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct
Date: Wed, 20 Jun 2018 14:44:36 +0900 (KST) [thread overview]
Message-ID: <20180620.144436.2267326438433785984.davem@davemloft.net> (raw)
In-Reply-To: <20180619165453.31894-1-mdf@kernel.org>
From: Moritz Fischer <mdf@kernel.org>
Date: Tue, 19 Jun 2018 09:54:53 -0700
> @@ -122,7 +122,7 @@ struct nixge_hw_dma_bd {
> u32 sw_id_offset;
> u32 reserved5;
> u32 reserved6;
> -};
> +} __packed;
As I understand it, based upon your replies to Florian, this bug doesn't
even show up with the current code. The problem only happens with some
64-bit changes you are working on.
So, the change is not valid right now.
And for the 64-bit changes, I agree with Florian that you should adjust
your implementation so that this __packed dance isn't necessary and
that you can avoid some MMIOs as well.
Thanks.
prev parent reply other threads:[~2018-06-20 5:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:54 [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct Moritz Fischer
2018-06-19 17:13 ` Florian Fainelli
2018-06-19 17:31 ` Moritz Fischer
2018-06-19 17:41 ` Florian Fainelli
2018-06-19 22:37 ` David Miller
2018-06-21 18:30 ` Moritz Fischer
2018-06-20 5:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620.144436.2267326438433785984.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).