From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] tc: fix batch force option Date: Wed, 20 Jun 2018 09:33:05 -0700 Message-ID: <20180620093305.1f23b4ed@xeon-e3> References: <1529479461-32048-1-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, chrism@mellanox.com To: Vlad Buslov Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:39120 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235AbeFTQdN (ORCPT ); Wed, 20 Jun 2018 12:33:13 -0400 Received: by mail-pl0-f67.google.com with SMTP id s24-v6so73446plq.6 for ; Wed, 20 Jun 2018 09:33:13 -0700 (PDT) In-Reply-To: <1529479461-32048-1-git-send-email-vladbu@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Jun 2018 10:24:21 +0300 Vlad Buslov wrote: > When sending accumulated compound command results an error, check 'force' > option before exiting. Move return code check after putting batch bufs and > freeing iovs to prevent memory leak. Break from loop, instead of returning > error code to allow cleanup at the end of batch function. Don't reset ret > code on each iteration. > > Fixes: 485d0c6001c4 ("tc: Add batchsize feature for filter and actions") > Reviewed-by: Roi Dayan > Reviewed-by: Chris Mi > Signed-off-by: Vlad Buslov Applied