From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH] bpfilter: fix build error Date: Wed, 20 Jun 2018 14:39:26 +0200 Message-ID: <20180620143926.50720aec@elisabeth> References: <20180619151620.1912-1-mcroce@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Alexei Starovoitov To: Matteo Croce Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752798AbeFTMjc (ORCPT ); Wed, 20 Jun 2018 08:39:32 -0400 In-Reply-To: <20180619151620.1912-1-mcroce@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 19 Jun 2018 17:16:20 +0200 Matteo Croce wrote: > bpfilter Makefile assumes that the system locale is en_US, and the > parsing of objdump output fails. > Set LC_ALL=C and, while at it, rewrite the objdump parsing so it spawns > only 2 processes instead of 7. > > Fixes: d2ba09c17a064 ("net: add skeleton of bpfilter kernel module") > Signed-off-by: Matteo Croce > --- > net/bpfilter/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile > index e0bbe7583e58..dd86b022eff0 100644 > --- a/net/bpfilter/Makefile > +++ b/net/bpfilter/Makefile > @@ -21,8 +21,10 @@ endif > # which bpfilter_kern.c passes further into umh blob loader at run-time > quiet_cmd_copy_umh = GEN $@ > cmd_copy_umh = echo ':' > $(obj)/.bpfilter_umh.o.cmd; \ > - $(OBJCOPY) -I binary -O `$(OBJDUMP) -f $<|grep format|cut -d' ' -f8` \ > - -B `$(OBJDUMP) -f $<|grep architecture|cut -d, -f1|cut -d' ' -f2` \ > + $(OBJCOPY) -I binary \ > + `LC_ALL=C objdump -f net/bpfilter/bpfilter_umh \ Why do you use objdump instead of $(OBJDUMP) now? I guess this might cause issues if you're cross-compiling. -- Stefano