From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Watson <davejwatson@fb.com>
Subject: Re: [PATCH net][RESEND] strparser: Don't schedule in workqueue in
 paused state
Date: Wed, 20 Jun 2018 10:32:10 -0700
Message-ID: <20180620173210.GA6064@davejwatson-mba.local>
References: <20180620215949.32334-1-vakul.garg@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <davem@davemloft.net>, <doronrk@fb.com>, <tom@quantonium.net>,
        <john.fastabend@gmail.com>, <netdev@vger.kernel.org>,
        <ebiggers@google.com>, <linux-kernel@vger.kernel.org>
To: Vakul Garg <vakul.garg@nxp.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20180620215949.32334-1-vakul.garg@nxp.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On 06/21/18 03:29 AM, Vakul Garg wrote:
> In function strp_data_ready(), it is useless to call queue_work if
> the state of strparser is already paused. The state checking should
> be done before calling queue_work. The change reduces the context
> switches and improves the ktls-rx throughput by approx 20% (measured
> on cortex-a53 based platform).

Nice find, works for me. Although current code isn't broken, just
slower, net-next would be fine.

Acked-by: Dave Watson <davejwatson@fb.com>