From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to
 skbedit
Date: Wed, 20 Jun 2018 15:40:27 -0300
Message-ID: <20180620184027.GA3446@localhost.localdomain>
References: <A371B54E-186D-4747-B4FB-744E201C3FE5@bu.edu>
 <38C2B0E3-E108-433B-906A-A2D72CEE4CAE@bu.edu>
 <E5616B71-959E-43FE-9096-BF523948ABB2@bu.edu>
 <264a03455daf28d33809ea77e4badc6a5ec5c9e6.camel@redhat.com>
 <9e0d0a90-4ad5-722f-1033-40b72c3841ed@digirati.com.br>
 <a1716a3accbbf9a72bbedb011862ac57eaddf481.camel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Michel Machado <michel@digirati.com.br>,
        "Fu, Qiaobin" <qiaobinf@bu.edu>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>
To: Davide Caratti <dcaratti@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qk0-f195.google.com ([209.85.220.195]:42752 "EHLO
        mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932184AbeFTSkb (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 20 Jun 2018 14:40:31 -0400
Received: by mail-qk0-f195.google.com with SMTP id j80-v6so332363qke.9
        for <netdev@vger.kernel.org>; Wed, 20 Jun 2018 11:40:30 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <a1716a3accbbf9a72bbedb011862ac57eaddf481.camel@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Jun 20, 2018 at 07:02:41PM +0200, Davide Caratti wrote:
...
> >     I agree that we should update the drop counter, but given that 
> > you're already converting the stats to be per-cpu counters, whatever we 
> > add now will be just symbolic since you're going to change it anyway.

It wouldn't be symbolic. One thing is to convert a given increment
into something else, another is to start increasing it for some (new)
reason.

> 
> that's ok for me also, as I can use the current v4 code for the rebase
> (and not wait for another respin) _ but let's hear what reviewers think.
> 
> >  If 
> > reviewers think that Qiaobin's patch must add the update line, could you 
> > provide the exact line and location so we avoid going to v6 of this patch?
> 
> In case, I was thinking of something like: 
> 
> https://elixir.bootlin.com/linux/v4.18-rc1/source/net/sched/act_ipt.c#L249
> 
> so, between 'err:' and 'spin_unlock(&d->tcf_lock)', insert a line like:
> 
> d->tcf_qstats.drop++;

I prefer the more complete version. Then it will have a more complete
(git) history and help people when troubleshooting.

Thanks,
Marcelo