From: Bas Vermeulen <bas@daedalean.ai>
To: netdev@vger.kernel.org
Cc: bas@daedalean.ai, Madalin Bucur <madalin.bucur@nxp.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] fman: don't set node on dpaa-ethernet platform device
Date: Thu, 21 Jun 2018 13:42:22 +0200 [thread overview]
Message-ID: <20180621114222.8326-1-bas@daedalean.ai> (raw)
Setting dev->node to the mac_node in dpaa_eth_add_device during probe
causes the mac_probe to be called again for the dpaa-ethernet.* device
that was just added.
Fix this by not setting dev->node, as it is not needed.
Signed-off-by: Bas Vermeulen <bas@daedalean.ai>
---
drivers/net/ethernet/freescale/fman/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 387eb4a88b72..9a265f862065 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -623,7 +623,6 @@ static struct platform_device *dpaa_eth_add_device(int fman_id,
goto no_mem;
}
- pdev->dev.of_node = node;
pdev->dev.parent = priv->dev;
set_dma_ops(&pdev->dev, get_dma_ops(priv->dev));
--
2.17.1
next reply other threads:[~2018-06-21 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 11:42 Bas Vermeulen [this message]
2018-06-23 1:27 ` [PATCH] fman: don't set node on dpaa-ethernet platform device David Miller
2018-06-26 7:00 ` Madalin-cristian Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621114222.8326-1-bas@daedalean.ai \
--to=bas@daedalean.ai \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox