Netdev List
 help / color / mirror / Atom feed
From: Ivan Vecera <cera@cera.cz>
To: netdev@vger.kernel.org
Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com,
	sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com
Subject: [PATCH net-next 5/8] be2net: move txcp field in be_tx_obj to eliminate holes in the struct
Date: Thu, 21 Jun 2018 16:43:27 +0200	[thread overview]
Message-ID: <20180621144330.12297-6-cera@cera.cz> (raw)
In-Reply-To: <20180621144330.12297-1-cera@cera.cz>

Before patch:
struct be_tx_obj {
        u32                        db_offset;            /*     0     4 */

        /* XXX 4 bytes hole, try to pack */

        struct be_queue_info       q;                    /*     8    56 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        struct be_queue_info       cq;                   /*    64    56 */
        struct be_tx_compl_info    txcp;                 /*   120     4 */

        /* XXX 4 bytes hole, try to pack */

        /* --- cacheline 2 boundary (128 bytes) --- */
        struct sk_buff *           sent_skb_list[2048];  /*   128 16384 */
        ...
}:

After patch:
struct be_tx_obj {
        u32                        db_offset;            /*     0     4 */
        struct be_tx_compl_info    txcp;                 /*     4     4 */
        struct be_queue_info       q;                    /*     8    56 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        struct be_queue_info       cq;                   /*    64    56 */
        struct sk_buff *           sent_skb_list[2048];  /*   120 16384 */
        ...
};

Signed-off-by: Ivan Vecera <cera@cera.cz>
---
 drivers/net/ethernet/emulex/benet/be.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index 716b4bc410f5..91ca8d132e87 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -240,9 +240,9 @@ struct be_tx_compl_info {
 
 struct be_tx_obj {
 	u32 db_offset;
+	struct be_tx_compl_info txcp;
 	struct be_queue_info q;
 	struct be_queue_info cq;
-	struct be_tx_compl_info txcp;
 	/* Remember the skbs that were transmitted */
 	struct sk_buff *sent_skb_list[TX_Q_LEN];
 	struct be_tx_stats stats;
-- 
2.16.4

  parent reply	other threads:[~2018-06-21 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 14:43 [PATCH net-next 0/8] be2net: small structures clean-up Ivan Vecera
2018-06-21 14:43 ` [PATCH net-next 1/8] be2net: remove unused old AIC info Ivan Vecera
2018-06-21 14:43 ` [PATCH net-next 2/8] be2net: remove unused old custom busy-poll fields Ivan Vecera
2018-06-21 14:43 ` [PATCH net-next 3/8] be2net: remove desc field from be_eq_obj Ivan Vecera
2018-06-21 14:43 ` [PATCH net-next 4/8] be2net: reorder fields in be_eq_obj structure Ivan Vecera
2018-06-21 14:43 ` Ivan Vecera [this message]
2018-06-21 14:43 ` [PATCH net-next 6/8] be2net: remove unused tx_jiffies field from be_tx_stats Ivan Vecera
2018-06-21 14:43 ` [PATCH net-next 7/8] be2net: re-order fields in be_error_recovert to avoid hole Ivan Vecera
2018-06-21 14:43 ` [PATCH net-next 8/8] be2net: move rss_flags field in rss_info to ensure proper alignment Ivan Vecera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180621144330.12297-6-cera@cera.cz \
    --to=cera@cera.cz \
    --cc=ajit.khaparde@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sriharsha.basavapatna@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox