From: Moritz Fischer <mdf@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: f.fainelli@gmail.com, mdf@kernel.org, keescook@chromium.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct
Date: Thu, 21 Jun 2018 13:30:50 -0500 [thread overview]
Message-ID: <20180621183050.GA9986@archbook> (raw)
In-Reply-To: <20180620.073750.642289685695664600.davem@davemloft.net>
Hi David,
On Wed, Jun 20, 2018 at 07:37:50AM +0900, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 19 Jun 2018 10:13:55 -0700
>
> > How could padding be inserted given than all of the structure members
> > are naturally aligned (all u32 type). Compiler bug?
>
> Agreed, this looks completely unnecessary.
>
> __packed should only be used when absolutely necessary because using
> it generates less efficient code on some architectures.
Thanks for your input, will fix with the whole series when I submit it.
- Moritz
next prev parent reply other threads:[~2018-06-21 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:54 [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct Moritz Fischer
2018-06-19 17:13 ` Florian Fainelli
2018-06-19 17:31 ` Moritz Fischer
2018-06-19 17:41 ` Florian Fainelli
2018-06-19 22:37 ` David Miller
2018-06-21 18:30 ` Moritz Fischer [this message]
2018-06-20 5:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621183050.GA9986@archbook \
--to=mdf@kernel.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).