From mboxrd@z Thu Jan  1 00:00:00 1970
From: Moritz Fischer <mdf@kernel.org>
Subject: Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor
 struct
Date: Thu, 21 Jun 2018 13:30:50 -0500
Message-ID: <20180621183050.GA9986@archbook>
References: <20180619165453.31894-1-mdf@kernel.org>
 <832bebb8-300d-e911-2946-5edfe82dc30a@gmail.com>
 <20180620.073750.642289685695664600.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: f.fainelli@gmail.com, mdf@kernel.org, keescook@chromium.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20180620.073750.642289685695664600.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Hi David,

On Wed, Jun 20, 2018 at 07:37:50AM +0900, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 19 Jun 2018 10:13:55 -0700
> 
> > How could padding be inserted given than all of the structure members
> > are naturally aligned (all u32 type). Compiler bug?
> 
> Agreed, this looks completely unnecessary.
> 
> __packed should only be used when absolutely necessary because using
> it generates less efficient code on some architectures.

Thanks for your input, will fix with the whole series when I submit it.

- Moritz