From: David Miller <davem@davemloft.net>
To: kai.heng.feng@canonical.com
Cc: ryankao@realtek.com, hayeswang@realtek.com, hau@realtek.com,
hkallweit1@gmail.com, romieu@fr.zoreil.com, bhelgaas@google.com,
acelan.kao@canonical.com, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/2] r8169: Don't disable ASPM in the driver
Date: Fri, 22 Jun 2018 14:08:31 +0900 (KST) [thread overview]
Message-ID: <20180622.140831.1245451103607060086.davem@davemloft.net> (raw)
In-Reply-To: <20180621083039.22545-1-kai.heng.feng@canonical.com>
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
Date: Thu, 21 Jun 2018 16:30:38 +0800
> Enable or disable ASPM should be done in PCI core instead of in the
> device driver.
>
> Commit ba04c7c93bbc ("r8169: disable ASPM") uses
> pci_disable_link_state() to disable ASPM, but it's not the best way to
> do it. If the device really wants to disable ASPM, we can use a quirk in
> PCI core to prevent the PCI core from setting ASPM before probe.
>
> Let's remove pci_disable_link_state() for now. Use PCI core quirks if
> any regression happens.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Applied.
prev parent reply other threads:[~2018-06-22 5:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 8:30 [PATCH net-next v4 1/2] r8169: Don't disable ASPM in the driver Kai-Heng Feng
2018-06-21 8:30 ` [PATCH net-next v4 2/2] r8169: Reinstate ASPM Support Kai-Heng Feng
2018-06-22 5:08 ` David Miller
2018-06-22 5:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622.140831.1245451103607060086.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acelan.kao@canonical.com \
--cc=bhelgaas@google.com \
--cc=hau@realtek.com \
--cc=hayeswang@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=ryankao@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox