From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chengguang Xu Subject: [PATCH] net/nfp: cast sizeof() to int when comparing with error code Date: Mon, 25 Jun 2018 15:33:18 +0800 Message-ID: <20180625073318.6828-1-cgxu519@gmx.com> Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, Chengguang Xu To: jakub.kicinski@netronome.com, davem@davemloft.net Return-path: Received: from mout.gmx.net ([212.227.15.19]:48131 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbeFYHeV (ORCPT ); Mon, 25 Jun 2018 03:34:21 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Negative error code will be larger than sizeof(). Signed-off-by: Chengguang Xu --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c index cd34097b79f1..37a6d7822a38 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c @@ -232,7 +232,7 @@ struct nfp_nffw_info *nfp_nffw_info_open(struct nfp_cpp *cpp) err = nfp_cpp_read(cpp, nfp_resource_cpp_id(state->res), nfp_resource_address(state->res), fwinf, sizeof(*fwinf)); - if (err < sizeof(*fwinf)) + if (err < (int)sizeof(*fwinf)) goto err_release; if (!nffw_res_flg_init_get(fwinf)) -- 2.17.1