From: Marcel Ziswiler <marcel@ziswiler.com>
To: netdev@vger.kernel.org
Cc: intel-wired-lan@lists.osuosl.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH] igb: allow optionally getting mac address from device tree
Date: Mon, 25 Jun 2018 10:00:42 +0200 [thread overview]
Message-ID: <20180625080042.32286-1-marcel@ziswiler.com> (raw)
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
For Embedded use where e.g. i210/i211 chips may be used without
external EEPROMs but regardless of whether or not the MAC address is
actually programmed into the iNVM the boot loader may choose to pass
the MAC address to be used via device tree. Therefore, allow for
optionally getting the MAC address from device tree data e.g. as
follows (excerpt from a TK1 based board, local-mac-address to be
filled in by boot loader):
pcie@1003000 {
...
/* I210 Gigabit Ethernet Controller */
pci@2,0 {
...
status = "okay";
pcie@0 {
reg = <0 0 0 0 0>;
local-mac-address = [00 00 00 00 00 00];
};
};
};
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index f707709969ac..0abf3698b05c 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -37,6 +37,7 @@
#include <linux/dca.h>
#endif
#include <linux/i2c.h>
+#include <linux/of_net.h>
#include "igb.h"
#define MAJ 5
@@ -2931,6 +2932,7 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
const struct e1000_info *ei = igb_info_tbl[ent->driver_data];
int err, pci_using_dac;
u8 part_str[E1000_PBANUM_LENGTH];
+ const void *iap;
/* Catch broken hardware that put the wrong VF device ID in
* the PCIe SR-IOV capability.
@@ -3122,7 +3124,11 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
break;
}
- if (eth_platform_get_mac_address(&pdev->dev, hw->mac.addr)) {
+ /* try to get the MAC address from device tree data */
+ iap = of_get_mac_address(pdev->dev.of_node);
+ if (iap)
+ memcpy(hw->mac.addr, iap, ETH_ALEN);
+ else if (eth_platform_get_mac_address(&pdev->dev, hw->mac.addr)) {
/* copy the MAC address out of the NVM */
if (hw->mac.ops.read_mac_addr(hw))
dev_err(&pdev->dev, "NVM Read Error\n");
--
2.14.4
next reply other threads:[~2018-06-25 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 8:00 Marcel Ziswiler [this message]
2018-06-25 8:05 ` [PATCH] igb: allow optionally getting mac address from device tree David Miller
2018-06-25 11:25 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625080042.32286-1-marcel@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox