From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next] route: add support for directed broadcast forwarding Date: Mon, 25 Jun 2018 12:09:56 +0300 Message-ID: <20180625090956.GA19457@splinter.mtl.com> References: <671e900d14a124f1de7785ee44c437d0826b9e2a.1529894708.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: network dev , davem@davemloft.net, David Ahern To: Xin Long Return-path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59525 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465AbeFYJJ7 (ORCPT ); Mon, 25 Jun 2018 05:09:59 -0400 Content-Disposition: inline In-Reply-To: <671e900d14a124f1de7785ee44c437d0826b9e2a.1529894708.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Xin, On Mon, Jun 25, 2018 at 10:45:08AM +0800, Xin Long wrote: > This patch implements the feature described in rfc1812#section-5.3.5.2 > and rfc2644. It allows the router to forward directed broadcast when > sysctl mc_forwarding is enabled. You mean bc_forwarding? > > Note that this feature could be done by iptables -j TEE, but it would > cause some problems: > - target TEE's gateway param has to be set with a specific address, > and it's not flexible especially when the route wants forward all > directed broadcasts. > - this duplicates the directed broadcasts so this may cause side > effects to applications. > > Besides, to keep consistent with other os router like BSD, it's also > necessary to implement it in the route rx path. Regarding the test you posted later in the thread, did you consider adding it as part of tools/testing/selftests/net/forwarding/ ? I believe you can write the test using VRFs instead of name spaces. Thanks