From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH] net/nfp: cast sizeof() to int when comparing with error code Date: Mon, 25 Jun 2018 11:11:24 -0700 Message-ID: <20180625111124.097a69ed@cakuba.netronome.com> References: <20180625073318.6828-1-cgxu519@gmx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org To: Chengguang Xu Return-path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:44207 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934772AbeFYSL3 (ORCPT ); Mon, 25 Jun 2018 14:11:29 -0400 Received: by mail-qt0-f196.google.com with SMTP id 92-v6so8337889qta.11 for ; Mon, 25 Jun 2018 11:11:29 -0700 (PDT) In-Reply-To: <20180625073318.6828-1-cgxu519@gmx.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 25 Jun 2018 15:33:18 +0800, Chengguang Xu wrote: > Negative error code will be larger than sizeof(). > > Signed-off-by: Chengguang Xu You should include the name of the tree in the tag, e.g. [PATCH net] or [PATCH net-next] and if it's a fix, i.e. directed at the net tree, you should add a fixes tag, in this case it would most likely be: Fixes: a0d8e02c35ff ("nfp: add support for reading nffw info") You can find this and more information about the development process of the networking subsystem in: https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt Acked-by: Jakub Kicinski Thank you!