From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net-next 1/5] ipv4: add __ip_queue_xmit() that supports
 tos param
Date: Mon, 25 Jun 2018 07:13:12 -0400
Message-ID: <20180625111312.GA16772@hmswarspite.think-freely.org>
References: <cover.1529892764.git.lucien.xin@gmail.com>
 <cover.1529892764.git.lucien.xin@gmail.com>
 <6d8aa86ce11166620c9fd4e50fdcce1baab69ab6.1529892764.git.lucien.xin@gmail.com>
 <20180625.162654.1306497955900954874.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
        linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from charlotte.tuxdriver.com ([70.61.120.58]:48687 "EHLO
        smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932089AbeFYLNw (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 25 Jun 2018 07:13:52 -0400
Content-Disposition: inline
In-Reply-To: <20180625.162654.1306497955900954874.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Jun 25, 2018 at 04:26:54PM +0900, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Mon, 25 Jun 2018 10:14:33 +0800
> 
> > +EXPORT_SYMBOL(__ip_queue_xmit);
> > +
> > +int ip_queue_xmit(struct sock *sk, struct sk_buff *skb, struct flowi *fl)
> > +{
> > +	return __ip_queue_xmit(sk, skb, fl, inet_sk(sk)->tos);
> > +}
> >  EXPORT_SYMBOL(ip_queue_xmit);
> 
> Maybe better to only export __ip_queue_xmit() and make ip_queue_xmit() an
> inline function in net/ip.h?
> 
I concur.  No need to export both here

Neil