From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: usb: asix: allow optionally getting mac address from device tree Date: Mon, 25 Jun 2018 17:28:06 +0200 Message-ID: <20180625152806.GA11603@lunn.ch> References: <20180625080108.32441-1-marcel@ziswiler.com> <1529926008.12558.14.camel@toradex.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Dean_Jenkins@mentor.com" , "andreyknvl@google.com" , "oneukum@suse.com" , "linux-usb@vger.kernel.org" To: Marcel Ziswiler Return-path: Content-Disposition: inline In-Reply-To: <1529926008.12558.14.camel@toradex.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > Now that you mentioned eth_platform_get_mac_address() on my igb attempt I am > wondering whether that would not also be the better approach for ASIX USB net > use. Looks like at least lan78xx already does it that way as well. > > What do you think? Hi Marcel eth_platform_get_mac_address() is preferred, since it will try DT, ACPI, and anything else the platform supports. Andrew