From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net 2/2] nfp: reject binding to shared blocks Date: Mon, 25 Jun 2018 22:51:10 +0200 Message-ID: <20180625205110.GH2161@nanopsycho> References: <20180625202246.28871-1-jakub.kicinski@netronome.com> <20180625202246.28871-3-jakub.kicinski@netronome.com> <20180625204021.GE2161@nanopsycho> <20180625135014.24f8f9c6@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org, John Hurley To: Jakub Kicinski Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:40133 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755697AbeFYUwb (ORCPT ); Mon, 25 Jun 2018 16:52:31 -0400 Received: by mail-wm0-f66.google.com with SMTP id z13-v6so5250699wma.5 for ; Mon, 25 Jun 2018 13:52:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180625135014.24f8f9c6@cakuba.netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Jun 25, 2018 at 10:50:14PM CEST, jakub.kicinski@netronome.com wrote: >On Mon, 25 Jun 2018 22:40:21 +0200, Jiri Pirko wrote: >> Mon, Jun 25, 2018 at 10:22:46PM CEST, jakub.kicinski@netronome.com wrote: >> >From: John Hurley >> > >> >TC shared blocks allow multiple qdiscs to be grouped together and filters >> >shared between them. Currently the chains of filters attached to a block >> >are only flushed when the block is removed. If a qdisc is removed from a >> >block but the block still exists, flow del messages are not passed to the >> >callback registered for that qdisc. For the NFP, this presents the >> >possibility of rules still existing in hw when they should be removed. >> > >> >Prevent binding to shared blocks until the kernel can send per qdisc del >> >messages when block unbinds occur. >> >> This is not nfp-specific problem. Should be handled differently. The >> driver has information about offloaded filters. On unbind, it have >> enough info to do the flush, doesn't it? > >Certainly. But this fix is simpler and sufficient. We need to >backport it back to 4.16. If we have to go through driver tables >and flush filters we may as well merge the reoffload series to net. Oh, I missed this is for net. Sorry. Acked-by: Jiri Pirko