From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v2 4/7] net: sched: cls_matchall: implement offload tcf_proto_op Date: Mon, 25 Jun 2018 23:36:56 +0200 Message-ID: <20180625213656.GN2161@nanopsycho> References: <20180625213010.13266-1-jakub.kicinski@netronome.com> <20180625213010.13266-5-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, xiyou.wangcong@gmail.com, jhs@mojatatu.com, gerlitz.or@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com, John Hurley To: Jakub Kicinski Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:35948 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbeFYViR (ORCPT ); Mon, 25 Jun 2018 17:38:17 -0400 Received: by mail-wm0-f68.google.com with SMTP id u18-v6so7057812wmc.1 for ; Mon, 25 Jun 2018 14:38:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180625213010.13266-5-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Jun 25, 2018 at 11:30:07PM CEST, jakub.kicinski@netronome.com wrote: >From: John Hurley > >Add the reoffload tcf_proto_op in matchall to generate an offload message >for each filter in the given tcf_proto. Call the specified callback with >this new offload message. The function only returns an error if the >callback rejects adding a 'hardware only' rule. > >Ensure matchall flags correctly report if the rule is in hw by keeping a >reference counter for the number of instances of the rule offloaded. Only >update the flag when this counter changes from or to 0. > >Signed-off-by: John Hurley >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko