From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v2 7/7] net: sched: call reoffload op on block callback reg Date: Mon, 25 Jun 2018 23:37:17 +0200 Message-ID: <20180625213717.GO2161@nanopsycho> References: <20180625213010.13266-1-jakub.kicinski@netronome.com> <20180625213010.13266-8-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, xiyou.wangcong@gmail.com, jhs@mojatatu.com, gerlitz.or@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com, John Hurley To: Jakub Kicinski Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:53715 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbeFYVii (ORCPT ); Mon, 25 Jun 2018 17:38:38 -0400 Received: by mail-wm0-f68.google.com with SMTP id x6-v6so10818087wmc.3 for ; Mon, 25 Jun 2018 14:38:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180625213010.13266-8-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Jun 25, 2018 at 11:30:10PM CEST, jakub.kicinski@netronome.com wrote: >From: John Hurley > >Call the reoffload tcf_proto_op on all tcf_proto nodes in all chains of a >block when a callback tries to register to a block that already has >offloaded rules. If all existing rules cannot be offloaded then the >registration is rejected. This replaces the previous policy of rejecting >such callback registration outright. > >On unregistration of a callback, the rules are flushed for that given cb. >The implementation of block sharing in the NFP driver, for example, >duplicates shared rules to all devs bound to a block. This meant that >rules could still exist in hw even after a device is unbound from a block >(assuming the block still remains active). > >Signed-off-by: John Hurley >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko