From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: INFO: rcu detected stall in vprintk_emit Date: Tue, 26 Jun 2018 13:22:08 +0900 Message-ID: <20180626042208.GA31439@jagdpanzerIV> References: <000000000000720530056f7f9b63@google.com> <20180626014924.GB11229@jagdpanzerIV> <20180625225937.43aee76c@vmware.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sergey Senozhatsky , syzbot , linux-kernel@vger.kernel.org, pmladek@suse.com, sergey.senozhatsky@gmail.com, syzkaller-bugs@googlegroups.com, Samuel Ortiz , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org To: Steven Rostedt Return-path: Content-Disposition: inline In-Reply-To: <20180625225937.43aee76c@vmware.local.home> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On (06/25/18 22:59), Steven Rostedt wrote: > > Or ratelimited error reporting and cond_resched() > > [that would be option B]: > > I don't think this is a printk() issue per se, so I think Option B is > the only option. You should not get stuck in an infinite loop if we run > short on memory. Perhaps we could have an Option C which would exit > this loop gracefully with some kind of error. But I haven't looked at > the surrounding code to be sure if that is possible. Agree. I like Option B - an endless loop is the root cause, at the same time filling up logbuf with useless data is useless. Can't tell if Option C is feasible, up to networking people. -ss